Skip to content

Appfunctions media attachments#27

Merged
keyboardsurfer merged 24 commits into
android:mainfrom
calebareeveso:appfunctions-media-attachments
Jul 21, 2026
Merged

Appfunctions media attachments#27
keyboardsurfer merged 24 commits into
android:mainfrom
calebareeveso:appfunctions-media-attachments

Conversation

@calebareeveso

@calebareeveso calebareeveso commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Screenshots

s-1 s-2 s-3 s-4

What I have done and why

Added support for sending image attachments and changing chat wallpapers across the Agent and ChatApp, and updated all code to work with appfunctions 1.0.0-alpha10 .

Summary of Changes

ChatApp:

  • Added imageUris to send(...) so users can attach images to chat messages.
  • Added updateChatWallpaper(...) so users can change a conversation's wallpaper.
  • Updated chat AppFunctions to the new 1.0.0-alpha10 AppFunctionService format.

Agent App:

  • Automatically grants temporary read permission (FLAG_GRANT_READ_URI_PERMISSION ) whenever sending local content:// image URIs to another app
  • Displays image preview cards in the chat window for AI-generated images
  • Fixed an API crash (HTTP 400 Duplicate function declaration) that happened when both phone and Wear OS companion apps were installed
  • Added Kotlin serialization plugin and MessageAttachmentConverter to persist message media attachments in Room DB

Caleb Areeveso added 6 commits July 8, 2026 20:22
agent: Add image generation appfunction
b61f0f2 
Change-Id: Ie5a3a97c4dc2eefe349f0df22313f2bc12fcfe01
fix: address gemini-code-assist bot code review feedback
81197ad 
Change-Id: Ie3fbb88ae72223cc9b1fb29ca226fdc045200104
agent & ChatApp: Integrate cross-app AppFunctions and media attachments
eccfb9b 
Change-Id: Id88dc93971c3c21a8044d125070785dd3c879fb9
Resolve merge conflicts with upstream 1.0.0-alpha10 and fix duplicate…
286f0e8 
… Gemini tool names

Change-Id: Id2ff4aadfceddbc3b2a4b720eb882323f0cad7d8
fix: Merge agent-image-gen into appfunctions-media-attachments and po…
0fdf2ae 
…rt wallpaper support

Change-Id: Ie24524f68e30243682a31d3b99701aae760fff20
fix: add sportless formatting
4bb9b27 
Change-Id: I5f3f8d62d3be770e5035fc1c785b346ca74695e1
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 10, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for custom chat wallpapers in the ChatApp and adds image generation capabilities to the AI agent using the Gemini API. Key changes include the creation of a WallpaperRepository to manage chat backgrounds, updates to the UI to render wallpapers, and enhancements to the agent's orchestrator to handle remote file references, download them to local cache, and grant URI permissions. Feedback on these changes highlights three main areas for improvement: adding connection and read timeouts to the HttpURLConnection used for downloading files, offloading blocking disk I/O operations in the wallpaper flow to Dispatchers.IO to prevent UI stutters, and wrapping contentResolver.openInputStream in a try-catch block to gracefully handle potential security or file-not-found exceptions.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread agent/app/src/main/java/com/example/appfunctions/agent/domain/AgentOrchestrator.kt Outdated
Comment thread ChatApp/shared/src/main/kotlin/com/example/chatapp/data/WallpaperRepository.kt Outdated
Comment thread ChatApp/shared/src/main/kotlin/com/example/chatapp/appfunctions/BaseChatAppFunctionService.kt Outdated
Caleb Areeveso added 6 commits July 10, 2026 11:39
fix: address gemini-code-assist bot code review feedback
c236907 
Change-Id: I7d56a269f7965e54ce98f84595a12f3035891056
style: apply spotless formatting and rename service files without spo…
7c2f3d7 
…tless suppressions

Change-Id: Ibee730a08f815dff8cc600845af1d2da3636e78b
refactor: break down generateImage into private helpers, improve null…
0ce6468 
… safety and readability

Change-Id: I584583bb8b04bb7a4530f880a6441574e125fbbd
style: apply spotless formatting and rename service files to match cl…
b642858 
…ass names

Change-Id: I7557376d8765ef9761534936177a8363f5b79808
refactor: Improve kotlin-readbility and break down generateImage into…
d678128 
… private helpers

Change-Id: I484c7cb582b8cd436fee8793119b434aa3d84784
test: refactor AgentOrchestratorTest expression functions to block bo…
9be5eef 
…dies and extract mock helpers

Change-Id: Id24a66497c47cc87d11cf37fec17fc196a710de9
utkarsh2827
utkarsh2827 approved these changes Jul 20, 2026
View reviewed changes
Comment thread agent/app/build.gradle.kts
Comment thread ChatApp/shared/src/main/kotlin/com/example/chatapp/data/WallpaperRepository.kt
Comment thread ChatApp/shared/src/main/kotlin/com/example/chatapp/data/WallpaperRepository.kt Outdated
Comment thread ChatApp/shared/src/main/kotlin/com/example/chatapp/data/WallpaperRepository.kt Outdated
keyboardsurfer and others added 10 commits July 20, 2026 16:39
@keyboardsurfer
Merge branch 'main' into agent-image-gen
16ca008
@keyboardsurfer
Merge branch 'main' into appfunctions-media-attachments
a30cfd0
docs: add KDoc documentation to WallpaperRepository
7bac6d4 
Change-Id: I99971c606c783a96e340cc8f947f65d90e71ab73
fix: copy new wallpaper file before deleting old files in WallpaperRe…
0d61c7c 
…pository

Change-Id: I2ccd86d2d895b70706477213478ea39cbffa33c6
Merge main into agent-image-gen
42134fb 
Change-Id: I810ce32ae9e5e908896475f42cd43d8b02980d25
fix: deduplicate function declarations in Gemini tool payload
cd99d5d 
Change-Id: I673954d3ebe987a570dadbdca5807e5b09744a90
style: apply spotless
e1e273b 
Change-Id: I056f58d80290c561500998f3f67ad89042007776
Merge public-fork/agent-image-gen into agent-image-gen
68740c4 
Change-Id: I81dc207c40dc2bb29996a1797e28818d6104f30c
Merge branch 'agent-image-gen' into appfunctions-media-attachments
a74d184 
Change-Id: If4daca546d0d699d4461010e9347c10343dc30a0
fix: include voiceNoteUri in KNOWN_FILE_REFERENCE_PARAM_NAMES and upd…
0fa0f26 
…ate test

Change-Id: Iba93fd0623d5e07f0ecf0a9f577db98fe2e33d99
@calebareeveso
calebareeveso requested a review from a team as a code owner July 21, 2026 08:14
Caleb Areeveso added 2 commits July 21, 2026 08:20
style: apply spotless formatting to InputBar.kt
d2850b4 
Change-Id: Ifeb2b15e846755bbbf351b8da9b617bd4d2f1539
Merge main into appfunctions-media-attachments
384b8e0 
Change-Id: I56067629e14109a1f3a43895fc55a239b6450f8f
@keyboardsurfer
keyboardsurfer merged commit d9cdc55 into android:main Jul 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keyboardsurfer keyboardsurfer keyboardsurfer approved these changes
+2 more reviewers
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
@utkarsh2827 utkarsh2827 utkarsh2827 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calebareeveso @keyboardsurfer @utkarsh2827